python312Packages.mlflow: 2.14.3 -> 2.16.2 #347104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ''; | ||
|
|
||
| gunicornScript = writeText "gunicornMlflow" '' | ||
| #!/usr/bin/env python |
There was a problem hiding this comment.
Suggested change
| #!/usr/bin/env python | |
| #!${python.interpreter} |
Why is that not in the entrypoint of the build system?
There was a problem hiding this comment.
No idea... I applied your suggestion.
There was a problem hiding this comment.
Can you try adding an entrypoint to setup.cfg or pyptoject.toml?
It would be really cool to avoid the python code hete
GaetanLepage
force-pushed
the
mlflow-master
branch
2 times, most recently
from
900bb29 to
c8bb670
Compare
|
GaetanLepage
force-pushed
the
mlflow-master
branch
from
c8bb670 to
3e3611e
Compare
|
I have no idea why, but this update seems to break a single test of |
vcunat
reviewed
Oct 8, 2024
| { | ||
| python3Packages, | ||
| writeText, | ||
| python, |
There was a problem hiding this comment.
The top-level python attribute is a deprecated alias, and that's detected by ofBorg eval. Perhaps just use python3Packages.python? (for easier overrides)
There was a problem hiding this comment.
Or you could remain with the previous way of just passing python3 and using python3.pkgs. (I don't know what's the best practice here)
GaetanLepage
force-pushed
the
mlflow-master
branch
from
3e3611e to
8e03a09
Compare
|
Looks certainly better than not building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
I was not able to get the tests working.
-> Should I leave the draft of my attempt in the derivation in case somebody wants to give it a try ?
cc @tbenst
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.